Streamline the creation of users

scripts/Windows/OS/Install.ps1

@@ -193,6 +193,9 @@ $null = New-Module {
 
                             Start-OneShot {
                                 switch (Get-OneShotTask) {
+                                    ([OneShotTask]::InitializeMSAccount) {
+                                        Initialize-UserCreation;
+                                    }
                                     ([OneShotTask]::DisableUAC) {
                                         Disable-UAC;
                                         Register-Setup;
@@ -533,58 +536,53 @@ $null = New-Module {
                                     Set-Stage ([SetupStage]::CreateUser);
                                 }
                                 ([SetupStage]::CreateUser) {
-                                    Start-ValhallaUserSetup;
+                                    $users = @(Get-Users);
-                                    Set-Stage ([SetupStage]::ConfigureUser);
+                                    $i = Get-CurrentUser;
-                                }
-                                ([SetupStage]::ConfigureUser) {
-                                    $userOption = "CurrentUser";
 
-                                    function Get-CurrentUser {
+                                    for (; $i -lt $users.Count; $i++) {
-                                        (Get-SetupOption $userOption) ?? 0;
+                                        $name = $users[$i];
-                                    }
+                                        Set-CurrentUser $i;
-
-                                    function Set-CurrentUser {
-                                        param([int] $Value)
-                                        Set-SetupOption $userOption $Value;
-                                    }
-
-                                    [string[]] $users = Get-Users;
-                                    $currentUser = Get-CurrentUser;
 
                                         if (Test-Admin) {
                                             Disable-BootMessage;
                                         }
 
-                                    if ($currentUser -lt $users.Count) {
+                                        while ((Get-UserStage) -ne ([UserStage]::Completed)) {
-                                        $user = Get-LocalUser $users[$currentUser];
+                                            switch (Get-UserStage) {
-                                        $msAccount = Get-UserConfig -UserName "$user" -Name "microsoftAccount";
+                                                ($null) {
+                                                    Set-UserStage ([UserStage]::Create);
+                                                    continue;
+                                                }
+                                                ([UserStage]::Create) {
+                                                    $msAccount = Get-UserConfig -UserName $name "microsoftAccount";
 
-                                        $adminGroup = @{
+                                                    if ($env:UserName -ne $name) {
-                                            SID = [SecurityIdentifier]::new([WellKnownSidType]::BuiltinAdministratorsSid, $null);
+                                                        New-ValhallaUser $name;
-                                        };
-
-                                        Add-LocalGroupMember `
-                                            @adminGroup `
-                                            $user `
-                                            -ErrorAction SilentlyContinue;
-
-                                        if ($env:UserName -ne "$user") {
-                                            Disable-LocalUser $env:UserName;
-                                            Enable-LocalUser $user;
 
                                                         if ($msAccount) {
-                                                Enable-UAC;
+                                                            Register-Setup -DefaultUser;
-                                                Disable-Autologin;
+                                                            logoff;
-                                                Enable-OneShotListener;
-                                                Set-BootMessage -Caption "Please Log In" -Message "Please log in using your new Microsoft Account ``$user``.";
                                                         } else {
-                                                Set-AutologinUser "$user";
+                                                            Restart-Intermediate;
                                                         }
 
-                                            Restart-Intermediate -DefaultUser;
+                                                        exit;
-                                            return;
                                                     } else {
-                                            $configure = {
+                                                        if ($msAccount) {
+                                                            if (-not (Test-Admin)) {
+                                                                Invoke-OneShot DisableUAC;
+                                                                Restart-Computer;
+                                                                return;
+                                                            }
+
+                                                            Clear-SetupRegistration;
+                                                            Disable-OneShotListener;
+                                                        }
+
+                                                        Set-UserStage ([UserStage]::Configure);
+                                                    }
+                                                }
+                                                (([UserStage]::Configure)) {
                                                     Deploy-SoftwareAction -Action ([InstallerAction]::ConfigureUser);
                                                     Remove-LocalGroupMember -Member "$user" @adminGroup -ErrorAction SilentlyContinue;
             
@@ -592,24 +590,8 @@ $null = New-Module {
                                                         Add-LocalGroupMember -Member "$user" -Name "$group";
                                                     }
                                                 }
-
-                                            if ($msAccount) {
-                                                if (-not (Test-Admin)) {
-                                                    Invoke-OneShot DisableUAC;
-                                                    Restart-Computer;
-                                                    return;
-                                                } else {
-                                                    & $configure;
-                                                    Clear-SetupRegistration;
-                                                    Disable-OneShotListener;
-                                                }
-                                            } else {
-                                                & $configure;
                                             }
                                         }
-
-                                        Set-CurrentUser ($currentUser + 1);
-                                        continue;
                                     }
 
                                     Set-IsFinished $true;

scripts/Windows/Scripts/Users.ps1

@@ -1,9 +1,10 @@
 using namespace System.Management.Automation.Host;
+using namespace System.Security.Principal;
 
 $null = New-Module {
     . "$PSScriptRoot/../../Common/Scripts/Config.ps1";
-    [string] $userOption = "SetupUser";
+    . "$PSScriptRoot/../../Common/Scripts/Operations.ps1";
-    [string] $userStageOption = "UserStage";
+    $loggedInUserOption = "LoggedInUser";
 
     enum UserStage {
         Create
@@ -12,34 +13,16 @@ $null = New-Module {
 
     <#
         .SYNOPSIS
-        Gets the current stage of the user creation.
+        Creates a new user for the PortValhalla setup.
-    #>
-    function Get-UserStage {
-        Get-SetupOption -Name $userStageOption;
-    }
 
-    <#
+        .PARAMETER Name
-        .SYNOPSIS
+        The name of the user to create.
-        Sets the current user creation stage.
-
-        .PARAMETER Value
-        The value to set the stage to.
     #>
-    function Set-UserStage {
+    function New-ValhallaUser {
         param(
-            [UserStage] $Value
+            [string] $Name
         )
 
-        Set-SetupOption -Name $userStageOption -Value $Value;
-    }
-
-    <#
-        .SYNOPSIS
-        Creates the configured users.
-    #>
-    function Start-ValhallaUserSetup {
-        [string[]] $users = Get-Users;
-
         function Add-MicrosoftAccount {
             param(
                 [string] $Name
@@ -55,7 +38,7 @@ $null = New-Module {
                             "Thus, you have to do it by yourself.",
                             "So sorry…") -join "`n");
 
-                    Write-Host "Create a user for ``$Name`` manually (because Windows is too stupid)…";
+                    Write-Host "Create a user for ``$Name`` manually… (because Windows is too stupid)";
                     $null = Read-Host "Hit enter once you're done";
 
                     $newUsers = @(Get-LocalUser | Where-Object { -not ($currentUsers -contains $_.Name) });
@@ -86,7 +69,6 @@ $null = New-Module {
 
                                         for ($i = 0; $i -lt $newUsers.Count; $i++) {
                                             $name = "$($newUsers[$i])";
-
                                             [ChoiceDescription]::new("&$($i + 1) - ``$name``", "Your user is ``$name``");
                                         }
                                     }), 0);
@@ -103,15 +85,44 @@ $null = New-Module {
                 }
             };
 
-            Write-Host "Renaming the new user to ``$Name``…";
+            Set-MSAccountName ([string]$newUser);
-            Rename-LocalUser $newUser $Name;
         }
 
-        for ($i = 0; $i -lt $users.Count; $i++) {
+        $msAccount = Get-UserConfig -UserName $Name "microsoftAccount";
-            Set-SetupOption $userOption $i;
+
-            $name = $users[$i];
+        if ($msAccount) {
-            Write-Host "Creating personal user ``$name``…";
+            if (Test-Admin) {
-            $displayName = Get-UserConfig -UserName $name "displayName";
+                Write-Host "Preparing environment for creating MS Account";
+                Enable-OneShotListener;
+                Enable-UAC;
+                Restart-Intermediate -CurrentUser;
+                exit;
+            }
+        }
+
+        Write-Host "Creating personal user ``$Name``…";
+
+        if ($msAccount) {
+            Add-MicrosoftAccount $Name;
+            Set-SetupOption $loggedInUserOption $env:UserName;
+            Invoke-OneShot ([OneShotTask]::InitializeMSAccount)
+        } else {
+            New-LocalUser -NoPassword @userArguments;
+            Initialize-UserCreation;
+        }
+    }
+
+    <#
+        .SYNOPSIS
+        Prepares the first login for initializing the current user under configuration.
+    #>
+    function Initialize-UserCreation {
+        $name = (@(Get-Users))[(Get-CurrentUser)];
+        $msAccount = Get-UserConfig -UserName $name "microsoftAccount";
+        $displayName = Get-UserConfig -UserName $Name "displayName";
+
+        Write-Host "Initializing user $name";
+        Write-Host "MS Account: $msAccount"
 
         $userArguments = @{
             name = $name;
@@ -121,13 +132,34 @@ $null = New-Module {
             $userArguments.fullName = $displayName;
         }
 
-            if (Get-UserConfig -UserName $name "microsoftAccount") {
+        $adminGroup = @{
-                Add-MicrosoftAccount $name;
+            SID = [SecurityIdentifier]::new([WellKnownSidType]::BuiltinAdministratorsSid, $null);
-            } else {
+        }
-                New-LocalUser -Disabled -NoPassword @userArguments;
+
+        if ($msAccount) {
+            Write-Host "Renaming $(Get-MSAccountName) to $name"
+            Rename-LocalUser (Get-MSAccountName) $name;
         }
 
         Set-LocalUser @userArguments;
+
+        if ($msAccount) {
+            Disable-LocalUser (Get-SetupOption $loggedInUserOption);
+        } else {
+            Disable-LocalUser $env:UserName;
+        }
+
+        Add-LocalGroupMember `
+            @adminGroup `
+            $name `
+            -ErrorAction SilentlyContinue;
+
+        if ($msAccount) {
+            Disable-Autologin;
+            Set-BootMessage -Caption "Please Log In" -Message "Please log in using your new Microsoft Account ``$name``.";
+            Write-Host "MS Account successfully initialized";
+        } else {
+            Set-AutologinUser "$name";
         }
     }
 };