From 6b269887f298b9259e375b734a2279bea236bba6 Mon Sep 17 00:00:00 2001 From: sunshineinabox Date: Mon, 10 Jul 2023 21:04:55 -0700 Subject: [PATCH] Address Feedback --- src/ARMeilleure/Translation/Translator.cs | 6 +++--- src/Ryujinx.Common/SystemInfo/SystemInfo.cs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ARMeilleure/Translation/Translator.cs b/src/ARMeilleure/Translation/Translator.cs index ef6c90fef..5bd8fbb18 100644 --- a/src/ARMeilleure/Translation/Translator.cs +++ b/src/ARMeilleure/Translation/Translator.cs @@ -57,7 +57,7 @@ namespace ARMeilleure.Translation private Thread[] _backgroundTranslationThreads; private volatile int _threadCount; - private static int physicalCoreCount; + private static int _physicalCoreCount; // FIXME: Remove this once the init logic of the emulator will be redone. @@ -121,13 +121,13 @@ namespace ARMeilleure.Translation _ptc.Disable(); - physicalCoreCount = SystemInfo.GetPhysicalCoreCount(); + _physicalCoreCount = SystemInfo.GetPhysicalCoreCount(); // Simple heuristic, should be user configurable in future. (1 for 4 core/ht or less, 2 for 6 core + ht // etc). All threads are normal priority except from the last, which just fills as much of the last core // as the os lets it with a low priority. If we only have one rejit thread, it should be normal priority // as highCq code is performance critical. - int unboundedThreadCount = Math.Max(1, (physicalCoreCount - 6) / 3); + int unboundedThreadCount = Math.Max(1, (_physicalCoreCount - 6) / 3); int threadCount = Math.Min(4, unboundedThreadCount); Thread[] backgroundTranslationThreads = new Thread[threadCount]; diff --git a/src/Ryujinx.Common/SystemInfo/SystemInfo.cs b/src/Ryujinx.Common/SystemInfo/SystemInfo.cs index 05eb7859c..306b81749 100644 --- a/src/Ryujinx.Common/SystemInfo/SystemInfo.cs +++ b/src/Ryujinx.Common/SystemInfo/SystemInfo.cs @@ -118,7 +118,7 @@ namespace Ryujinx.Common.SystemInfo Arguments = "-n hw.physicalcpu", UseShellExecute = false, RedirectStandardOutput = true, - CreateNoWindow = true + CreateNoWindow = true, } };