manuth/Ryujinx
1
0
Fork 0
mirror of https://git.naxdy.org/Mirror/Ryujinx.git synced 2025-01-08 08:53:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add a new test and fix for logging statements in child blocks

Browse source
This commit is contained in:
TSR Berry 2024-01-16 13:48:13 +01:00
parent 40bceebacb
commit 81988c9ed8
No known key found for this signature in database
GPG key ID: 52353C0A4CCA15E2
2 changed files with 32 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Ryujinx.Analyzers/CatchClauseAnalyzer.cs
View file

@ -146,9 +146,9 @@ namespace Ryujinx.Analyzers
bool exceptionLogged = false;
// Iterate through all expression statements
foreach (var statement in catchClauseSyntax.Block.Statements)
foreach (var blockNode in catchClauseSyntax.Block.DescendantNodes())
{
if (statement is not ExpressionStatementSyntax expressionStatement)
if (blockNode is not ExpressionStatementSyntax expressionStatement)
{
continue;
}

30
src/Ryujinx.Tests.Analyzers/CatchClauseAnalyzerTests.cs
View file

@ -214,6 +214,36 @@ public class MyClass
}
}
}
";
await Verifier.VerifyAnalyzerAsync(text).ConfigureAwait(false);
}
[Fact]
public async Task LogWithIdentifierInSubBlock_NoDiagnostic()
{
string text = _loggerText + @"
public class MyClass
{
public void MyMethod9()
{
try
{
Console.WriteLine(""test"");
}
catch (Exception ex)
{
string testString = ""first time?"";
if (1 == 1)
{
Ryujinx.Common.Logging.Logger.Info?.Print(Ryujinx.Common.Logging.LogClass.Application, $""test: {testString} Error: {ex.Message}"");
}
Console.WriteLine(""Test"");
}
}
}
";
await Verifier.VerifyAnalyzerAsync(text).ConfigureAwait(false);