manuth/Ryujinx
1
0
Fork 0
mirror of https://git.naxdy.org/Mirror/Ryujinx.git synced 2025-02-22 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

No need to initialize attributes on the SPIR-V backend anymore

Browse source
This commit is contained in:
gdkchan 2021-08-30 18:51:32 -03:00 committed by riperiperi
parent 4513e8b226
commit c6fbaf844e
1 changed files with 0 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
Ryujinx.Graphics.Shader/CodeGen/Spirv/SpirvGenerator.cs
View file

@ -82,45 +82,6 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Spirv
Declarations.DeclareLocals(context, function);
Declarations.DeclareLocalForArgs(context, info.Functions);
if (funcIndex == 0)
{
var v4Type = context.TypeVector(context.TypeFP32(), 4);
var zero = context.Constant(context.TypeFP32(), 0f);
var one = context.Constant(context.TypeFP32(), 1f);
// Some games will leave some elements of gl_Position uninitialized,
// in those cases, the elements will contain undefined values according
// to the spec, but on NVIDIA they seems to be always initialized to (0, 0, 0, 1),
// so we do explicit initialization to avoid UB on non-NVIDIA gpus.
if (context.Config.Stage == ShaderStage.Vertex)
{
var elemPointer = context.GetAttributeVectorPointer(new AstOperand(OperandType.Attribute, AttributeConsts.PositionX), true);
context.Store(elemPointer, context.CompositeConstruct(v4Type, zero, zero, zero, one));
}
// Ensure that unused attributes are set, otherwise the downstream
// compiler may eliminate them.
// (Not needed for fragment shader as it is the last stage).
if (context.Config.Stage != ShaderStage.Compute &&
context.Config.Stage != ShaderStage.Fragment &&
!context.Config.GpPassthrough)
{
for (int attr = 0; attr < Declarations.MaxAttributes; attr++)
{
if (context.Config.TransformFeedbackEnabled)
{
throw new NotImplementedException();
}
else
{
int currAttr = AttributeConsts.UserAttributeBase + attr * 16;
var elemPointer = context.GetAttributeVectorPointer(new AstOperand(OperandType.Attribute, currAttr), true);
context.Store(elemPointer, context.CompositeConstruct(v4Type, zero, zero, zero, one));
}
}
}
}
Generate(context, function.MainBlock);
context.FunctionEnd();