SlothBusters/gruppe02-slothbusters-projekt3-catan
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Implement roads and settlements #27

Merged
aebertan merged 9 commits from implement-roads-and-settlements into dev 2025-07-06 12:24:46 +00:00
Conversation 2 Commits 9 Files changed 6 +247 -23
aebertan commented 2021-12-03 18:05:45 +00:00 (Migrated from github.zhaw.ch)
Copy link

Changes made in this pull request will add methods for building structures. Furthermore resource holders can now handle resource maps and structure classes now contain their enum types. Also the SiedlerStreet class was changed to extend SiedlerStructure class instead of SiedlerSettlement.

Changes made in this pull request will add methods for building structures. Furthermore resource holders can now handle resource maps and structure classes now contain their enum types. Also the SiedlerStreet class was changed to extend SiedlerStructure class instead of SiedlerSettlement.
zumbrseb (Migrated from github.zhaw.ch) requested changes 2021-12-03 20:42:35 +00:00
zumbrseb (Migrated from github.zhaw.ch) left a comment
Copy link

Well done. Looks good.
There are a few places where the javadoc is missing.

Well done. Looks good. There are a few places where the javadoc is missing.
app/src/main/java/ch/zhaw/catan/SiedlerBoard.java
@ -20,0 +32,4 @@
/**
* Verifies if the selected location is a valid location for a settlement.
*
* @return true, if the location of the settlement is valid.
zumbrseb (Migrated from github.zhaw.ch) commented 2021-12-03 20:27:45 +00:00
Copy link

JavaDoc is missing

JavaDoc is missing
app/src/main/java/ch/zhaw/catan/SiedlerBoard.java
@ -20,0 +116,4 @@
* Verifies if the settlement has an adjacent field.
*
* @return true, if there is an adjacent field.
*/
zumbrseb (Migrated from github.zhaw.ch) commented 2021-12-03 20:37:48 +00:00
Copy link

javadoc

javadoc
app/src/main/java/ch/zhaw/catan/model/ResourceHolder.java
zumbrseb (Migrated from github.zhaw.ch) commented 2021-12-03 20:30:22 +00:00
Copy link

Consider changing the name to incrementResources() for consistency (or changing incrementResource(resource, by) above to addResource(resourceMap)). The same goes for removeResources(resourceMap) and removeResource(resource, by)

Consider changing the name to `incrementResources()` for consistency (or changing `incrementResource(resource, by)` above to `addResource(resourceMap)`). The same goes for `removeResources(resourceMap)` and `removeResource(resource, by)`
costajon (Migrated from github.zhaw.ch) approved these changes 2021-12-04 20:47:04 +00:00
costajon (Migrated from github.zhaw.ch) left a comment
Copy link

Looks good to me. Nicely done

Looks good to me. Nicely done
Sign in to join this conversation.
Reviewers
No reviewers
zumbrseb
costajon
Labels
Clear labels   
bug

Something isn't working

  
ci

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
ci
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Task 1: Base game done
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SlothBusters/gruppe02-slothbusters-projekt3-catan#27
No description provided.
Delete branch "implement-roads-and-settlements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?