Commit graph

194 commits

Author SHA1 Message Date
sunshineinabox
c53f58a4a9 Resolve issue with primitive toplogy
Primitive Restart Enable should depend on Extended dynamic state 2 extension not 1

Resolve Primitive restart enable

Fix MoltenVK crash
2024-08-03 23:24:49 -07:00
sunshineinabox
3b398adbe6 Refactor PipelineUid and pack TopologyClass
Remove basepipelineindex as its extraneous
2024-08-03 19:22:46 -07:00
sunshineinabox
59ef2ac799 Accidental change 2024-08-02 18:17:28 -07:00
sunshineinabox
ce450dc08e Invert logic to only set flags dirty if those are supported. 2024-08-02 07:27:44 -07:00
sunshineinabox
023f3ed44f Resolve build errors 2024-08-01 19:21:32 -07:00
sunshineinabox
fa801ba472 Match other code in project 2024-08-01 19:17:59 -07:00
sunshineinabox
9b02fd6dc0 Conver to TopologyClass from Vulkan Topology 2024-08-01 08:19:11 -07:00
sunshineinabox
adc7528b54 Why cast when you don't need to cast 2024-07-31 18:56:06 -07:00
sunshineinabox
1bcc9c029a Remove redundant logic, just use max possible dynamic states 2024-07-31 18:51:44 -07:00
sunshineinabox
38c9ec925c Whitespace fix 2024-07-31 18:22:29 -07:00
sunshineinabox
3f7a3ac558 Adapt changes from #7102 for dynamic states 2024-07-31 18:18:46 -07:00
sunshineinabox
7b480edf86
Merge branch 'master' into MoreDynamicStatesPartOne 2024-07-31 17:17:24 -07:00
sunshineinabox
da11dc1288 Only pass Tesselation state create info if dynamic state is not supported 2024-07-31 17:12:57 -07:00
sunshineinabox
693f268090 Accidental change 2024-07-31 08:18:58 -07:00
sunshineinabox
fb964b514c Do not set patch control points dynamic state if there is no tessalation control shader. Thank you riperiperi 2024-07-31 08:14:26 -07:00
sunshineinabox
1b9e42bdb4 Should not just check for extension. This is more correct. 2024-07-30 18:17:49 -07:00
riperiperi
698e36bbd2
Vulkan: Force topology to PatchList for Tessellation (#7102)
Vulkan spec states that input topology should always be PatchList when a tessellation pipeline is present. The AMD GPU on windows crashes so hard it BSODs the machine if this isn't the case, so it's forced here just in case.

I'm not sure what providing a different topology here would even do, as you'd think it would always be a patch list input.
2024-07-30 21:48:30 -03:00
sunshineinabox
7396c05b35 Resolve crash 2024-07-29 20:32:52 -07:00
riperiperi
ccd330ba0f
Vulkan: Add missing barriers for texture to buffer copy (#7092)
This barrier has always been missing, but it only became apparent when #7012 merged.

I also added some barriers in case the target buffer used here is used by other commands, though right now it isn't.

Fixes a regression where water would turn white on AMD GPUs with the proprietary driver. May fix other issues on this driver.
2024-07-25 16:34:30 -03:00
sunshineinabox
e7a4299400 Minor change 2024-07-23 22:09:56 -07:00
sunshineinabox
ea44670330 Set logicOp and DepthCompareOp only if enabled 2024-07-23 22:03:47 -07:00
sunshineinabox
2cba50a9ed Move TopologyClass conversoin to EnumConversion.cs 2024-07-23 21:54:01 -07:00
sunshineinabox
b66f6ce673 Resolve some validation errors 2024-07-23 20:58:47 -07:00
sunshineinabox
a5052013f3 Fix some conditions 2024-07-23 20:25:23 -07:00
sunshineinabox
7610236816 Resolve merge error 2024-07-19 17:36:29 -07:00
sunshineinabox
afe4d581ee
Merge branch 'master' into MoreDynamicStatesPartOne 2024-07-18 07:32:07 -07:00
riperiperi
1a919e99b2
Vulkan: Defer guest barriers, and improve image barrier timings (#7012)
* More guarantees for buffer correct placement, defer guest requested buffers

* Split RP on indirect barrier rn

* Better handling for feedback loops.

* Qualcomm barriers suck too

* Fix condition

* Remove unused field

* Allow render pass barriers on turnip for now
2024-07-17 20:21:32 -03:00
Isaac Marovitz
344f4f52c1
Remove CommandBufferScoped Dependencies (#6958) 2024-07-16 17:01:06 -03:00
MutantAura
eb212aa91b
misc: Re-order and manually update DriverID to name. (#7027)
* Re-order and update DriverID -> Name.

* Fix whitespace
2024-07-15 19:27:59 -03:00
gdkchan
07435ad844
Use draw clear on Adreno, instead of vkCmdClearAttachments (#7013)
* Use draw clear on Adreno, instead of vkCmdClearAttachments

* Fix GTX TITAN detection
2024-07-10 17:52:45 -03:00
gdkchan
1668ba913f
Force dynamic state update after rasterizer discard disable (#7007) 2024-07-09 23:31:01 -03:00
gdkchan
a830eb666b
Disallow concurrent fence waits on Adreno (#7001)
* Disallow concurrent fence waits on Adreno

* Ensure locks are released if exceptions are thrown
2024-07-07 19:33:28 -03:00
gdkchan
cfc75d7e78
Disable descriptor set template updates for buffer textures on Adreno (#7002)
* Do not use template updates for buffer textures and buffer images

* No need to do it for images

* Simply buffer texture existence check

* Pipeline is now unused on DescriptorSetUpdater
2024-07-07 19:19:55 -03:00
gdkchan
c525d7d9a9
Force Vulkan swapchain re-creation when window size changes (#7003) 2024-07-07 19:02:11 -03:00
sunshineinabox
feb67dede6 Avoid setting depth bias state when not needed. 2024-07-04 23:38:21 -07:00
sunshineinabox
086656b736 Missed changes during merge 2024-07-04 23:03:22 -07:00
sunshineinabox
1d5a449931
Merge branch 'master' into MoreDynamicStatesPartOne 2024-07-04 22:54:17 -07:00
sunshineinabox
1a0a351a15
Resolve some Vulkan validation errors (#6915)
* Fix some validation errors

* Whitespace correction

* Resolve some runtime validation errors.

* Whitespace

* Properly fix usage realted validation error by setting Extended Usage image creation flag.

* Only if supported

* Remove checking extension for features that are core functionality of Vulkan 1.2
2024-06-26 09:21:44 -03:00
sunshineinabox
933c9c89ff Resolve logic op validation error only primitive topology pending 2024-06-03 21:10:13 -07:00
sunshineinabox
266649929f Clean up for some clarity and attempt to resolve some validation errors. 2024-06-02 21:00:18 -07:00
gdkchan
c0f2491eae
Vulkan separate descriptor set fixes (#6895)
* Ensure descriptor sets are only re-used when all command buffers using it have completed

* Fix some SPIR-V capabilities

* Set update after bind flag if we exceed limits

* Simpler fix for Intel

* Format whitespace

* Make struct readonly

* Add barriers for extra set arrays too
2024-06-02 22:40:28 -03:00
sunshineinabox
d7c6474729
GPU: Remove unused dynamic state and pipeline settings (#6796)
* Dynamic state for Depth Bounds should not be passed to PipelineDynamicStateCreateInfo as the command to set them is never called.

Do not pass pointer to viewport and scissor as those dynamic states should be supported on all devices.

Same as above for DepthBias values.

* Code Review Suggestion

* Pipeline derivation is not implemented and is not suggested.

* Depth Bounds are not used.
2024-06-02 22:32:10 -03:00
jhorv
1ecc8fbc3b
New pooled memory types (#6821)
* feat: add new types MemoryOwner and SpanOwner

* use SpanOwner instead of new array allocation

* change for loop condition to `fences.Length` instead of `count` to elide Span boundary checks on `fences`
2024-06-02 22:24:14 -03:00
sunshineinabox
966c5d463c Sleep Deprivation 2024-05-30 07:52:05 -07:00
sunshineinabox
985c648860 Bring up pipeline converter inline with dynamic states. 2024-05-30 07:52:05 -07:00
sunshineinabox
16a4374ae8 Fix whitespace 2024-05-29 10:16:14 -07:00
sunshineinabox
d8d33417e9 Fix oversight with implementing Primitive Topology Dynamic State 2024-05-29 10:14:12 -07:00
sunshineinabox
e6492f8e78 Reduce unneeded state changes 2024-05-29 09:45:56 -07:00
sunshineinabox
5c65880ec0 Whitespaces 2024-05-29 09:16:44 -07:00
sunshineinabox
88786ba29c Missed change 2024-05-29 08:44:08 -07:00